feat(studio): Additional numerical range filters - #577

web/packages/common/src/hooks/useStudioDataViewState/index.ts (1)

484-503: 🗄️ Data Integrity & Integration | 🔵 Trivial | 💤 Low value

Possible silent filter collision via Object.fromEntries.

If filterFieldMap (function or record form) maps two distinct filter ids to the same key, Object.fromEntries silently drops the earlier entry — one active UI filter would be dropped without any warning. Not exploited by current callers (getExperimentFilterField maps distinct ids to distinct keys), but nothing here guards against it as the mapping function grows.

🛡️ Optional dedup guard

-      result.filter = Object.fromEntries(
-        debouncedColumnFilters
-          .filter((f) => { ... })
-          .map((f) => {
-            const mappedKey =
-              typeof filterFieldMap === 'function' ? filterFieldMap(f.id) : filterFieldMap?.[f.id];
-            return [mappedKey ?? f.id, f.value];
-          })
-      ) as Partial<FilterType>;
+      const entries = debouncedColumnFilters
+        .filter((f) => { ... })
+        .map((f) => {
+          const mappedKey =
+            typeof filterFieldMap === 'function' ? filterFieldMap(f.id) : filterFieldMap?.[f.id];
+          return [mappedKey ?? f.id, f.value] as const;
+        });
+      if (process.env.NODE_ENV !== 'production') {
+        const seen = new Set<string>();
+        for (const [key] of entries) {
+          if (seen.has(key)) console.warn(`apiFilter: duplicate mapped key "${key}" — a filter was dropped`);
+          seen.add(key);
+        }
+      }
+      result.filter = Object.fromEntries(entries) as Partial<FilterType>;

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@web/packages/common/src/hooks/useStudioDataViewState/index.ts` around lines
484 - 503, The filter assembly in useStudioDataViewState is vulnerable to silent
collisions when filterFieldMap returns the same mapped key for multiple
debouncedColumnFilters entries, because Object.fromEntries will overwrite
earlier values. Update the filter-building logic around debouncedColumnFilters
to detect duplicate mapped keys before constructing result.filter, and either
skip duplicates deterministically or surface a clear warning/error when
filterFieldMap (function or record form) maps multiple ids to the same key.

web/packages/studio/src/components/dataViews/ExperimentGroupDataView/index.tsx (1)

48-56: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Duplicate evaluator-<name> regex — extract a shared helper.

The same /^evaluator-(.+)$/ pattern is duplicated in deriveEvaluatorNames (util.ts) and here. Two independent copies of the evaluator-id convention risk silent drift if the naming scheme ever changes.

Proposed refactor

+// util.ts
+export const parseEvaluatorId = (id: string): string | undefined =>
+  id.match(/^evaluator-(.+)$/)?.[1];

-  const evaluatorMatch = id.match(/^evaluator-(.+)$/);
-  if (evaluatorMatch) return `evaluators.${evaluatorMatch[1]}.mean`;
+  const evaluatorName = parseEvaluatorId(id);
+  if (evaluatorName) return `evaluators.${evaluatorName}.mean`;

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@web/packages/studio/src/components/dataViews/ExperimentGroupDataView/index.tsx`
around lines 48 - 56, The evaluator-id regex is duplicated between
getExperimentFilterField and deriveEvaluatorNames, so extract the
/^evaluator-(.+)$/ parsing into a shared helper and reuse it from both places.
Update the helper to return the evaluator name/field mapping once, then have
ExperimentGroupDataView and util.ts call that shared function instead of
maintaining separate copies.